Fix disabled and readonly on trix field

[zhephyn]

Description

The Trix field has no straightforward way to render disabled input. To bypass this, the suggested approach was to render the Trix show component within the edit form if either disabled or readonly is set to true.

Show page

Edit page

The body of the event is shown instead of the Trix field editor on the Edit page when disabled or readonly are set to true like below:

field :body, as: :trix, disabled: true

Fixes #3888

Checklist:

• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• I have added tests that prove my fix is effective or that my feature works

[qlty-cloud-legacy]

Code Climate has analyzed commit 4911fb7 and detected 0 issues on this pull request.

View more on Code Climate.

[zhephyn]

@Paul-Bob I've laid out an initial approach to fix the Trix field readonly bug

However currently the edit_component.html.erb file could use some refactoring, specifically the show component duplication. I was thinking of extracting the show component into a partial but wanted to run it by you first and see if you think its a sustainable approach.

Lmk what you think. Thanks

[zhephyn]

I've added tests for this as well.

[Paul-Bob]

Hi @zhephyn, you're on fire! Thanks for this contribution.

The approach is on the right track, but I think we can achieve a more elegant execution.

Take a look at how the component_for_view method works, every field has it, and it essentially returns the component used to render a field based on the current view.

We can override that method within the Trix field file and perform the readonly/disabled check there. If the view is a form (view.form?) and the field is readonly or disabled, the method can return the show component instead. This way, we avoid burdening the edit component with duplicative logic from the show component.

Let me know if this makes sense or if you have any questions.

Thanks again, really appreciate your contributions!

[zhephyn]

@Paul-Bob New changes are up. Kindly take a look whenever its convenient for you.

[Paul-Bob]

LGTM!

Thank you @zhephyn