enhancement: add clear_license_response_on_deploy configuration option #3892
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This update introduces a new configuration attribute to control the clearing of the license response after deployment. The default value is set to true
Paul-Bob
added
the
Enhancement
|
Code Climate has analyzed commit aaf39e9 and detected 0 issues on this pull request. View more on Code Climate. |
|
This PR has been merged into Please check the release guide for more information. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds
clear_license_response_on_deploy, which is set totrueby default and can be configured asfalse.This setting is introduced to handle a very specific use case where an application could send thousands of license verification requests per day, whereas the expected amount, assuming the cache is functioning correctly, is roughly one request every 6 hours.
By default, the license response is cleared on each deploy to ensure freshness. However, in certain environments where deploys are frequent and predictable, and excessive license calls are undesirable, setting this option to
falsecan significantly reduce the number of redundant license verifications.An example where this might happen is when the application is configured to start a large number of pods. Each pod, when booting Avo, clears the cached response and triggers a new license request, resulting in a high volume of redundant calls.