add jsonb to fields mapping #3824
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
JSONB fields should be displayed as
code
, just like JSON fields.Checklist:
Manual review steps
Use
discover_columns
with a model that has a JSONB column. Without this PR, the column is not displayed, with this PR it is.Happy to add tests if necessary.
Also, defining the
FIELDS_MAPPING
const could be cleaned up a bit, since many fields have the same value, e.g.: