Skip to content

enhancement: extend reload_records to support grid view #3780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 35 commits into from
Aug 13, 2025

Conversation

m7madmagdy
Copy link
Contributor

@m7madmagdy m7madmagdy commented Apr 4, 2025

Description

Fixes #3718

Support reload_records with grid and map views after running an action.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

Screenshots & recording

Screencast.from.04-06-2025.09.20.49.PM.webm

Manual review steps

  1. Step 1
  2. Step 2

Manual reviewer: please leave a comment with output from the test if that's the case.

@github-actions github-actions bot added the Fix label Apr 4, 2025
Copy link

qlty-cloud-legacy bot commented Apr 4, 2025

Code Climate has analyzed commit 3358458 and detected 0 issues on this pull request.

View more on Code Climate.

@m7madmagdy m7madmagdy changed the title send view_type to reload_records method Fix: extend reload_records to support grid view Apr 4, 2025
@m7madmagdy m7madmagdy marked this pull request as ready for review April 6, 2025 19:29
@m7madmagdy m7madmagdy requested a review from adrianthedev April 6, 2025 19:30
Copy link
Contributor

@Paul-Bob Paul-Bob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into this @m7madmagdy

The view type should be inferred by Avo.

@m7madmagdy m7madmagdy requested a review from Paul-Bob April 8, 2025 11:42
@m7madmagdy m7madmagdy marked this pull request as draft April 8, 2025 11:45
Copy link
Contributor

@Paul-Bob Paul-Bob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @m7madmagdy, I noticed that you requested a review and then marked the PR as a draft.

Feel free to ping me once it's ready for a full review.

@m7madmagdy
Copy link
Contributor Author

Hi @Paul-Bob

This change looks good and much cleaner
I will add a test for this feature and update the documentation with a short paragraph mentioning that this feature is available for grid items

Thanks for the great refactor

@Paul-Bob
Copy link
Contributor

Paul-Bob commented May 6, 2025

@m7madmagdy , please re-request a review once the tests and docs are up for a final review.

image

@m7madmagdy m7madmagdy requested a review from Paul-Bob May 12, 2025 12:35
@m7madmagdy
Copy link
Contributor Author

@Paul-Bob, I requested a review
I updated the avo docs, but sorry, I don't have time to write tests

Copy link
Contributor

This PR has been marked as stale because there was no activity for the past 15 days.

@github-actions github-actions bot added the Stale label May 28, 2025
@Paul-Bob Paul-Bob removed the Stale label May 28, 2025
Copy link
Contributor

This PR has been marked as stale because there was no activity for the past 15 days.

Copy link
Contributor

Closing this because there was no activity for the past 15 days. Feel free to reopen if new information pops up ✌️

@github-actions github-actions bot closed this Jun 29, 2025
@Paul-Bob Paul-Bob reopened this Aug 13, 2025
Copy link
Contributor

@Paul-Bob Paul-Bob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @m7madmagdy and @a7madM for your contribution on this PR

@Paul-Bob Paul-Bob force-pushed the fix/reload-records-with-gridview branch from 11dcc5e to f96cfa6 Compare August 13, 2025 12:49
@Paul-Bob Paul-Bob added Enhancement Not necessarily a feature, but something has improved and removed Fix Stale labels Aug 13, 2025
@Paul-Bob Paul-Bob changed the title Fix: extend reload_records to support grid view enhancement: extend reload_records to support grid view Aug 13, 2025
@Paul-Bob Paul-Bob merged commit 10c588e into avo-hq:main Aug 13, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Not necessarily a feature, but something has improved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

reload_records not working with the Grid view
4 participants