-
-
Notifications
You must be signed in to change notification settings - Fork 292
enhancement: extend reload_records
to support grid view
#3780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhancement: extend reload_records
to support grid view
#3780
Conversation
Code Climate has analyzed commit 3358458 and detected 0 issues on this pull request. View more on Code Climate. |
view_type
to reload_records
methodreload_records
to support grid view
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for looking into this @m7madmagdy
The view type should be inferred by Avo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @m7madmagdy, I noticed that you requested a review and then marked the PR as a draft.
Feel free to ping me once it's ready for a full review.
Hi @Paul-Bob This change looks good and much cleaner Thanks for the great refactor |
@m7madmagdy , please re-request a review once the tests and docs are up for a final review. |
@Paul-Bob, I requested a review |
This PR has been marked as stale because there was no activity for the past 15 days. |
This PR has been marked as stale because there was no activity for the past 15 days. |
Closing this because there was no activity for the past 15 days. Feel free to reopen if new information pops up ✌️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks @m7madmagdy and @a7madM for your contribution on this PR
11dcc5e
to
f96cfa6
Compare
reload_records
to support grid viewreload_records
to support grid view
Description
Fixes #3718
Support
reload_records
with grid and map views after running an action.Checklist:
Screenshots & recording
Screencast.from.04-06-2025.09.20.49.PM.webm
Manual review steps
Manual reviewer: please leave a comment with output from the test if that's the case.