-
-
Notifications
You must be signed in to change notification settings - Fork 292
feature: Add as_badge and :id type to Discreet Information #3715
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Code Climate has analyzed commit e46cc30 and detected 0 issues on this pull request. View more on Code Climate. |
@rctneil awesome work! great idea with the Can you please make the badge smaller so it fits better and post an updated screenshot. |
- Add badged version of timestamps modifier - Allow id modifier to not always use a badge - Make badged items as small as possible
Hi @adrianthedev I've made some changes. I tried to make the badged items as small as possible. Had to reduce the icon size if they are badged. Also tweaked colours so they are more subtle. Also added variants of :id and :timestamps as :id_badged and :timestamps_badged. ![]() Changes:
Do let me know your thoughts! @adrianthedev Unsure what happened with the last commit. Not sure why that is there? I do apologise that my got knowledge is very hazy. :-/ |
Hey @rctneil thanks for sending this in. I don't exactly know how this happened, but I wanted to push some changes to this branch but accidentally pushed to I did one change to the API. instead of Would you mind writing the docs for this feature? |
I've just seen the changes. I apologise for not getting it exactly as you wanted. You should have commented and i'd have given it another pass to improve it further. Sorry again Ok, i'll look at documentation. Is this just a case of cloning down another repo? Neil |
No need to apologize, really. There weren't any indications. I usually do that, leave a review for changes, but I had a few spare minutes and tried to upload them myself. As you may have noticed I pushed to The docs are in this repo. Thanks for your contribution! |
@adrianthedev Ok, docs are submitted. I hope i've done that right. Really excited to see my changes in a public release. As I said, my git knowledge is kinda flimsy so just trying to work through it. I hope people like this small tweak to the excellent discreet information feature! |
Description
Create a new default type for Discreet Information called
:id
that shows the ID in the header area rather than having to have a field. Also adds anas_badge
option to be able to display items up there as badges. Used by the:id
type.My first actual tweak that I know is simple but I hope you like!
Fixes # (issue)
Checklist:
Screenshots & recording
Manual review steps
Manual reviewer: please leave a comment with output from the test if that's the case.