enhancement: Detect polymorphic associations in generator

[Nevelito]

Description

Changes:

• implement detect_polymorphic_associations to resource_ganerator
• add specs

Fixes # (issue)
#3536

Checklist:

• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• I have added tests that prove my fix is effective or that my feature works

[qlty-cloud-legacy]

Method detect_polymorphic_associations has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.

[qlty-cloud-legacy]

Code Climate has analyzed commit d7adb9a and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category	Count
Complexity	1

View more on Code Climate.

[Paul-Bob]

Thanks for working on this, @Nevelito!

I have a few questions:

[Paul-Bob]

This PR is looking good @Nevelito

Let's just change the message when types are empty and add the types on the test, otherwise is good to merge.

Thank you for this contribution!

[Nevelito]

I think reduce 3 lines in resource_generator is impossible, we can reduce one here and move first " if " to first line:

fields[name] =
              if association.polymorphic?
                field_with_polymorphic_association(association)
              elsif association.is_a?(ActiveRecord::Reflection::ThroughReflection)
                field_from_through_association(association)
              else
                ::Avo::Mappings::ASSOCIATIONS_MAPPING[association.class]
              end

Of course if we want to keep the code readable

[Paul-Bob]

@Nevelito, I noticed that the generated types aren't constants.

They should be formatted like this: types: [Team, Project, Post, Fish]

Alternatively, types: [::Team, ::Project, ::Post, ::Fish] is also valid.

However, my last suggestion mistakenly converted types: [:Team, :Project, :Post, :Fish] into types: ["Team", "Project", "Post", "Fish"], both of which are incorrect.

[Nevelito]

I tried to use constantize witch should fix this issue but it returns types like this

types: [Team(id: integer, name: string, description: text, created_at: datetime, updated_at: datetime, url: string, color: string), Project(id: inte ...

[Paul-Bob]

I tried to use constantize witch should fix this issue but it returns types like this

types: [Team(id: integer, name: string, description: text, created_at: datetime, updated_at: datetime, url: string, color: string), Project(id: inte ...

I know, I don't know a easy way to achieve this, could you do some research on this please?

[Nevelito]

I created alias with new inspect function and keep original inspect in function original_inspect, now it works as it should but let me know what you think

[Paul-Bob]

I created alias with new inspect function and keep original inspect in function original_inspect, now it works as it should but let me know what you think

@Nevelito you did that change on the spec/dummy/app/models/application_record.rb which is inside Avo's dummy application. What will happen on user's applications that will not have this monkey patch? Most provably will not work as expected and the types will be rendered as: types: [Team(id: integer, name: string, description: text, created_at: datetime, updated_at: datetime, url: string, color: string), Project(id: inte ... which is not ideal. We want this way of rendering types: types: [Team, Project, Post, Fish] on all the applications

Suggesting this change to all the users is not ideal and monkey patching the ActiveRecord::Base it's also not reasonable.

Let's try to achieve this output: types: [Team, Project, Post, Fish] without monkey-patches if possible

[Nevelito]

I am not sure if it is possible, I tried to find something but nothing works, only changing inspect gave us wanted result but I see that we can not make like that because of this is in dummy app. I not sure what can we do now.

[Paul-Bob]

Thanks you for this contribution @Nevelito !