Skip to content

Conversation

adrianthedev
Copy link
Collaborator

@adrianthedev adrianthedev commented Dec 15, 2024

Description

Fixes #3531

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

Screenshots & recording

Manual review steps

  1. Go to an edit page
  2. Make some changes
  3. when you are focused on an input field run cmd+return
  4. observe how the form is submitted

Manual reviewer: please leave a comment with output from the test if that's the case.

Copy link

qlty-cloud-legacy bot commented Dec 15, 2024

Code Climate has analyzed commit f289f89 and detected 0 issues on this pull request.

View more on Code Climate.

@Paul-Bob Paul-Bob merged commit 77b412b into main Dec 16, 2024
20 checks passed
@Paul-Bob Paul-Bob deleted the feature/cmd-return-to-submit-form branch December 16, 2024 02:04
Copy link
Contributor

This PR has been merged into main. The functionality will be available in the next release.

Please check the release guide for more information.

@xeron
Copy link

xeron commented Dec 22, 2024

Not sure if related but this might have broken Chrome autofill: #3553

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Cmd Enter to submit form
3 participants