Skip to content

Conversation

mihaimdm22
Copy link
Contributor

@mihaimdm22 mihaimdm22 commented Oct 27, 2020

Let me know what can be improved
Thanks!

*Documentation also updated for 'Showing / Hiding fields on different views' and 'Password Field' sections.

@mihaimdm22 mihaimdm22 added the Fix label Oct 27, 2020
@codecov
Copy link

codecov bot commented Oct 27, 2020

Codecov Report

Merging #171 into master will increase coverage by 0.50%.
The diff coverage is 94.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #171      +/-   ##
==========================================
+ Coverage   96.03%   96.53%   +0.50%     
==========================================
  Files          87      130      +43     
  Lines        1890     3550    +1660     
==========================================
+ Hits         1815     3427    +1612     
- Misses         75      123      +48     
Impacted Files Coverage Δ
lib/avo/app/tools_manager.rb 50.00% <50.00%> (ø)
spec/dummy/app/policies/user_policy.rb 56.25% <53.33%> (ø)
spec/dummy/app/avo/filters/published_filter.rb 66.66% <66.66%> (ø)
lib/avo/app/action.rb 80.00% <80.00%> (ø)
lib/avo/engine.rb 85.71% <85.71%> (ø)
lib/avo/app/fields/boolean_field.rb 93.75% <87.50%> (ø)
lib/avo/app/app.rb 89.70% <89.70%> (ø)
lib/avo/app/fields/key_value_field.rb 90.90% <90.90%> (ø)
.../avo/app/fields/field_extensions/has_field_name.rb 91.66% <91.66%> (ø)
...lds/field_extensions/visible_in_different_views.rb 92.85% <92.85%> (ø)
... and 170 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e7a76e...246fbd9. Read the comment docs.

Copy link
Collaborator

@adrianthedev adrianthedev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a few tweaks. Let me know what you think.

@mihaimdm22 mihaimdm22 merged commit a9e38e3 into master Oct 28, 2020
@mihaimdm22 mihaimdm22 deleted the fix/only_on-not-working-edit branch October 28, 2020 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants