Skip to content

Conversation

@avh4
Copy link
Owner

@avh4 avh4 commented Nov 12, 2016

This changes #5 to show the list of packages you might need to check on at the end. The output looks like this (and with links directly to the issues pages):

SUCCESS! Your project's dependencies and code have been upgraded.
However, your project may not yet compile due to API changes in your
dependencies.

See https://github.com/elm-lang/elm-platform/blob/master/upgrade-docs/0.18.md
and the documentation for your dependencies for more information.

WARNING! Several of your dependencies have not yet been upgraded to
support Elm 0.18. You can create an issue to request the packages be
upgraded here:
  - https://github.com/Fresheyeball/elm-tuple-extra/issues
  - https://github.com/NoRedInk/elm-rails/issues
  - https://github.com/NoRedInk/elm-simple-fuzzy/issues
  - https://github.com/NoRedInk/elm-string-extra/issues
  - https://github.com/NoRedInk/nri-elm-css/issues
  - https://github.com/eeue56/elm-all-dict/issues
  - https://github.com/eeue56/elm-default-dict/issues
  - https://github.com/jinjor/elm-diff/issues
  - https://github.com/mdgriffith/elm-style-animation/issues
  - https://github.com/mgold/elm-date-format/issues
  - https://github.com/rluiten/elm-date-extra/issues
  - https://github.com/rluiten/elm-text-search/issues
  - https://github.com/rtfeldman/elm-validate/issues
  - https://github.com/shmookey/cmd-extra/issues
  - https://github.com/thebritican/elm-autocomplete/issues
  - https://github.com/wernerdegroot/listzipper/issues

@avh4
Copy link
Owner Author

avh4 commented Nov 12, 2016

@eeue56 ^^

@avh4 avh4 force-pushed the upgrade-dependencies-final-message branch from 5837b0e to 669b526 Compare November 12, 2016 18:30
upgrade.js Outdated

if (packagesRequiringUpgrade.length > 0) {
process.stdout.write(
'WARNING! Several of your dependencies have not yet been upgraded to \n'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Several -> give exact count

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

packagesRequiringUpgrade.forEach(function(packageName) {
process.stdout.write(' - https://github.com/' + packageName + '/issues\n');
});
process.stdout.write('\n');
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fwiw, we could also automate making 0.18 upgrade PRs

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh making the PRs... Hmm.. That's a cool idea! I think if we wanted to automate the PRs, it would be better to separately just go through all the published packages and create the PRs (as an independent, one-time script), and not have elm-upgrade to that, since so many people will be running it.

Also, I didn't want to automate issue creation because most likely there will already be an issue created, and I don't want all package maintainers to get a bunch of duplicate issue reports.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, that's what I did for 0.16. It was a bit trickier than because some things just couldn't be done by hand

@avh4 avh4 self-assigned this Nov 12, 2016
@avh4 avh4 removed their assignment Nov 12, 2016
@eeue56 eeue56 merged commit 2fdc0fa into master Nov 12, 2016
@eeue56 eeue56 deleted the upgrade-dependencies-final-message branch March 5, 2018 12:55
avh4 added a commit that referenced this pull request Sep 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants