-
Notifications
You must be signed in to change notification settings - Fork 12
Show links to unupgraded dependencies at the end #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@eeue56 ^^ |
5837b0e to
669b526
Compare
upgrade.js
Outdated
|
|
||
| if (packagesRequiringUpgrade.length > 0) { | ||
| process.stdout.write( | ||
| 'WARNING! Several of your dependencies have not yet been upgraded to \n' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Several -> give exact count
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
| packagesRequiringUpgrade.forEach(function(packageName) { | ||
| process.stdout.write(' - https://github.com/' + packageName + '/issues\n'); | ||
| }); | ||
| process.stdout.write('\n'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fwiw, we could also automate making 0.18 upgrade PRs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh making the PRs... Hmm.. That's a cool idea! I think if we wanted to automate the PRs, it would be better to separately just go through all the published packages and create the PRs (as an independent, one-time script), and not have elm-upgrade to that, since so many people will be running it.
Also, I didn't want to automate issue creation because most likely there will already be an issue created, and I don't want all package maintainers to get a bunch of duplicate issue reports.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, that's what I did for 0.16. It was a bit trickier than because some things just couldn't be done by hand
This changes #5 to show the list of packages you might need to check on at the end. The output looks like this (and with links directly to the issues pages):