-
Notifications
You must be signed in to change notification settings - Fork 4
[com1] Rheological Models for debris-flow simulations #1169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use citations and references in the documentation
Issue #1170 contains further ideas/tasks regarding rheological models. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
General question, also @awirb : should we move the whole fricition stuff to an [FRICTION] section instead of keeping it in [GENERAL]
Furthermore: as already discussed, we should make clear that one community talks about rhological models, the other about friction types, but both mean the same thing. (in the documentation)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, 2 last points, after which I'm happy to merge this one :-)
f18c77e
to
b884ea4
Compare
Standardtests ok |
changes in:
com1DFA.com1DFACfg.ini -> input parameters
com1DFA.com1DFA.DFAIterate() -> adding new models to frictModelList
com1DFA.DFAfunctionsCython.computeForceC() -> adding new functions
com1DFA.com1DFA.createReportDict() -> adding new models to report output
theoryCom1DFA.rst -> documentation
https://docs.avaframe.org/en/rheologicalmodels/