fix: improve grep portability in extract_tunnel_url function #193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use temp file approach instead of in-place editing to avoid compatibility issues between GNU sed (-i without space) and BSD sed (-i with space for backup extension). This ensures harbor.sh works correctly regardless of which sed implementation is installed (common issue on macOS with Homebrew's GNU sed).
- Add OS detection to use appropriate grep syntax - Use basic regex (-oE) for macOS/Darwin instead of Perl regex (-oP) - Maintains compatibility across GNU and BSD grep implementations - Fixes tunnel URL extraction on macOS systems 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Problem
The extract_tunnel_url() function was using Perl regex syntax (-oP) which is not available in macOS's default grep implementation, causing tunnel URL extraction to fail on macOS systems.
Solution
Added conditional logic to detect the operating system and use the appropriate grep syntax:
Test plan
🤖 Generated with Claude Code