Add shutdown implementation
#1120
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martskins
force-pushed
the
shutdown-impl
branch
from
88dd616 to
a06038c
Compare
martskins
force-pushed
the
shutdown-impl
branch
from
a06038c to
40991bd
Compare
Contributor
|
Nice call! I can test this later. |
martskins
added a commit
to martskins/LanguageClient-neovim
that referenced
this pull request
Dec 6, 2020
martskins
added a commit
to martskins/LanguageClient-neovim
that referenced
this pull request
Dec 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the
shutdownrequest and fixes two issues. The first issue is that we were usingexitinstead ofshutdownto indicate a server shutdown. The second issue is that shutting down (or exiting) the server would now cause the client to try and restart the server (because of the newly added auto-restart logic), so this checks whether the server was running before running the restart logic to fix that.I've also modified the
LanguageClientStopcommand to issue ashutdowninstead ofexitnow, and callexitas a callback toshutdown.