Updates scikit-learn version to 0.22 #774
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bins in the GradientBostingClassifier. The by-the-book approach would be to generate new metalearning data, but the impact of not doing so, in this case, should be very small
…eature preprocessing
gui-miotto
commented
Feb 3, 2020
| @@ -35,7 +35,7 @@ def test_default_configuration_regression(self): | |||
| predictor = regressor.fit(X_train_trans, Y_train) | |||
| predictions = predictor.predict(X_test_trans) | |||
| accuracy = sklearn.metrics.mean_squared_error(predictions, Y_test) | |||
| self.assertAlmostEqual(accuracy, 20.193400000000004, places=2) | |||
| self.assertAlmostEqual(accuracy, 17.93480710955056, places=2) | |||
There was a problem hiding this comment.
The accuracies decreased. Couldn't figure out why, even after carefully inspecting the list of changes.
There was a problem hiding this comment.
The metric is actually misnamed. Could you please change the metric to error? Then it's clear that it actually improved by going to 0.22.2.
There was a problem hiding this comment.
Ah! This is good news. :-)
I'll rename it.
gui-miotto
commented
Feb 3, 2020
| res["default_boston_iterative_sparse"] = None | ||
| res["default_diabetes"] = 0.32614416980439365 | ||
| res["default_diabetes_iterative"] = None | ||
| res["default_diabetes_sparse"] = 0.1298841767742679 | ||
| res["default_diabetes_sparse"] = 0.12989753681434824 |
There was a problem hiding this comment.
Apparently ridge regression had a small bug when dealing with X sparse. It has been fixed in v0.22.
Model details here: scikit-learn/scikit-learn#13995
…efore the examples" This reverts commit 0bb7f2a.
Codecov Report
@@ Coverage Diff @@
## development #774 +/- ##
===============================================
- Coverage 85.37% 85.33% -0.05%
===============================================
Files 129 129
Lines 9204 9204
===============================================
- Hits 7858 7854 -4
- Misses 1346 1350 +4
Continue to review full report at Codecov.
|
mfeurer
reviewed
Feb 10, 2020
franchuterivera
pushed a commit
to franchuterivera/auto-sklearn
that referenced
this pull request
Aug 21, 2020
* initial commit * fix some unittests * Edit configurations.csv to reflect the new value of the hyperpar max_bins in the GradientBostingClassifier. The by-the-book approach would be to generate new metalearning data, but the impact of not doing so, in this case, should be very small * fixed some more unittests * fixed some more unit tests * changed assert values of the unit test of the extra_tree_regression feature preprocessing * small variable renaming * trying to fix the CI issue that makes all tests be executed before the examples * Revert "trying to fix the CI issue that makes all tests be executed before the examples" This reverts commit 0bb7f2a. * try again to fix the CI issue * try again to fix the CI issue * trying to fix CI issue * corrects typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.