-
Notifications
You must be signed in to change notification settings - Fork 1.3k
First draft of multi-objective optimization #1455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 14 commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
2885692
First draft of multi-objective optimization
mfeurer 4e361b7
Feedback from Eddie
mfeurer 77a223e
Make metric internally always a list
mfeurer c3b5072
Fix most examples
mfeurer fc89c68
Take further feedback into account
mfeurer 1a09c12
Fix unit tests
mfeurer 19251e8
Fix one more example
mfeurer 177d913
Add multi-objective example
mfeurer 98beb3a
Simplify internal interface
mfeurer 93cdbfc
Act on further feedback
mfeurer 610cda8
Fix bug
mfeurer 1557131
Update cv_results_ for multi-objective sklearn compliance
mfeurer 75c3eb4
Update leaderboard for multi-objective optimization
mfeurer 1f90ec8
Include Feedback from Katharina
mfeurer a9227b8
Take offline feedback into account
mfeurer 2c36d45
Take offline feedback into account
mfeurer 1f1d218
Eddie's feedback
mfeurer 8de1e5a
Fix metadata generation unit test
mfeurer 08c3bd0
Test for metrics with the same name
mfeurer fdfed85
Fix?
mfeurer fe67618
Test CV results
mfeurer 0aa65e9
Test leaderboard for multi-objective optimization
mfeurer b1a0c72
Last batch of unit tests added
mfeurer d432e07
Include Eddie's feedback
mfeurer File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume this is a point of API conflict? It would be good to know about all the metrics for a model but at the end of the day, we currently only support one and so we choose the first?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it would be good to know about all the metrics. I will look into returning multiple metrics here (should be possible).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see my comment wrt this in the PR comment at the top.