Skip to content

Conversation

ekalosak
Copy link

No description provided.

@renesass renesass mentioned this pull request Oct 26, 2022
3 tasks
@renesass renesass changed the base branch from main to development October 26, 2022 06:51
@renesass
Copy link
Collaborator

@hvarfner Can you approve this change?

@hvarfner
Copy link
Contributor

Sure. Want me to look or just approve?

@renesass
Copy link
Collaborator

It's basically one line only so having a quick look might help. Because in your original implementation, you just returned 0.

@hvarfner
Copy link
Contributor

Now, I actually looked. This should not be related to my work, since it is the standard GP over functions and not the PiBO work with priors over the optimum. I still don't mind having a look at it, but I am not the one who implemented this (assuming that there hasn't been a mixup somewhere).

@renesass
Copy link
Collaborator

renesass commented Oct 26, 2022

Oh, I'm sorry, I thought the priors came together with PiBO. But @mfeurer did actually implement the origin implementation long time ago.

@renesass renesass merged commit e4ec3c7 into automl:development Oct 26, 2022
github-actions bot pushed a commit that referenced this pull request Oct 26, 2022
@mfeurer
Copy link
Contributor

mfeurer commented Oct 26, 2022

Hey, just had a look. This should be fine as the result is still a constant.

@renesass
Copy link
Collaborator

I figured so, it's already part of v2.0.0a2. Thanks @ekalosak for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants