Skip to content

Conversation

@mfeurer
Copy link
Contributor

@mfeurer mfeurer commented Jul 31, 2025

No description provided.

@mfeurer mfeurer requested review from LukasFehring and benjamc July 31, 2025 09:55
Copy link
Collaborator

@LukasFehring LukasFehring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM;
Thank you for the contribution

@benjamc benjamc merged commit 1d0bbf9 into development Jul 31, 2025
11 checks passed
@benjamc benjamc deleted the simplify_local_search_code branch July 31, 2025 12:37
Copy link
Contributor

@eddiebergman eddiebergman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did the order matter, as this removes ordering?

@LukasFehring
Copy link
Collaborator

@eddiebergman I thought since Python 3.7 sets are not unordered anymore, but are iterated deterministically.

@eddiebergman
Copy link
Contributor

eddiebergman commented Aug 4, 2025

@LukasFehring that's dictionaries, as far as I'm aware, sets are ordered according to their hash values, which is dependant upon PYTHONHASHSEED

Python 3.12.8 (main, Jan 14 2025, 23:36:58) [Clang 19.1.6 ] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> strings = ["a", "b", "c", "d", "e"]
>>> strings_set = set()
>>> for s in strings:
...     strings_set.add(s)
...
>>> print(list(strings_set))
['c', 'e', 'a', 'b', 'd']

@LukasFehring
Copy link
Collaborator

Ah, my mistake :)
Nevertheless, I just checked the code, and I believe this does not pose a problem in this case, as all of the starting points are later utilized in the local search hill climbing. If you find anything to the contrary, please let us know :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants