Skip to content

Conversation

thijssnelleman
Copy link
Contributor

Changed the TrialValue to hold CPU time and have SMBO use this value to calculate its budgets

  • Same behaviour as the original 'time' variable, except in its calculation tries to estimate CPU time with process_time instead.
  • Added in to TrialValue object, RunHistory and SMBO so it can be recorded and correctly calculate the remaining CPU budget

Pytest are passing (on my machine)

Copy link
Collaborator

@benjamc benjamc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there any way to test the new cpu return? if yes, please add a little test

otherwise, codewise the PR LGTM, it only needs a bit more documentation.
You can basically copy/paste the description for cpu_time everywhere.

@benjamc benjamc self-assigned this Nov 27, 2024
@benjamc benjamc added this to the v2.3 milestone Nov 27, 2024
@thijssnelleman
Copy link
Contributor Author

Added in CPU time tests in target function runner tests

@benjamc benjamc merged commit 000dd2d into automl:development Nov 29, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants