Suppress finalization for AutofacWebApiDependencyScope #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This will probably be redundant if autofac/Autofac.WebApi#69, which completely removes the finalizer from |
srogovtsev
force-pushed
the
gc-suppress-finalize-for-dependency-scope
branch
from
80c5971 to
40f6263
Compare
srogovtsev
changed the title
|
I merged in autofac/Autofac.WebApi#69 and that will be released as soon as my PR for the build/housekeeping autofac/Autofac.WebApi#70 gets merged in. I'll update the minimum Given that, I'll close this one and move forward with the stated plan. If it turns out that's not enough, we can always revisit this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As shown in #15, the fact that we don't dispose
AutofacWebApiDependencyScopecan lead to undesired resource consumption byAutofacWebApiDependencyScopehanging in the finalizer queue. This PR aims to fix this by suppressing finalization forAutofacWebApiDependencyScope, as we know that its resources (ILifetimeScope) will be properly disposed in the caller.