Skip to content

Added a flag to disable tracing of health check requests #2494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

davide-baldo
Copy link
Contributor

@davide-baldo davide-baldo commented Jul 10, 2025

Added the option --otel-disable-healthcheck-tracing to disable health-check requests for both HTTP and GRPC requests.
This PR addresses the issue Allow disabling health check traces

image

I'm not used to writing Go, so please let me know if there is anything I can do to improve the code or make it more idiomatic.

I've also manually validated the result using a locally deployed Jaeger.

@davide-baldo davide-baldo requested a review from a team as a code owner July 10, 2025 16:13
@github-actions github-actions bot added area/cli Affects the command line area/tooling Affects the dev or user toolchain (e.g. tests, ci, build tools) area/api http Affects the HTTP Gateway API labels Jul 10, 2025
Copy link

github-actions bot commented Jul 10, 2025

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@davide-baldo
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

authzedbot added a commit to authzed/cla that referenced this pull request Jul 10, 2025
@davide-baldo davide-baldo force-pushed the reduce-health-check-noise branch 2 times, most recently from 18d055f to e66d682 Compare July 14, 2025 14:40
Copy link

codecov bot commented Jul 14, 2025

Codecov Report

❌ Patch coverage is 49.39759% with 42 lines in your changes missing coverage. Please review.
✅ Project coverage is 39.45%. Comparing base (7b70ff2) to head (8d7a2f4).
⚠️ Report is 23 commits behind head on main.

Files with missing lines Patch % Lines
internal/gateway/gateway.go 0.00% 27 Missing ⚠️
pkg/cmd/server/defaults.go 62.17% 12 Missing and 2 partials ⚠️
pkg/cmd/server/server.go 94.74% 1 Missing ⚠️

❌ Your project check has failed because the head coverage (39.45%) is below the target coverage (75.00%). You can increase the head coverage or adjust the target coverage.

❗ There is a different number of reports uploaded between BASE (7b70ff2) and HEAD (8d7a2f4). Click for more details.

HEAD has 43 uploads less than BASE
Flag BASE (7b70ff2) HEAD (8d7a2f4)
54 11
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2494       +/-   ##
===========================================
- Coverage   77.43%   39.45%   -37.97%     
===========================================
  Files         417      376       -41     
  Lines       51071    47129     -3942     
===========================================
- Hits        39541    18592    -20949     
- Misses       9038    26977    +17939     
+ Partials     2492     1560      -932     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@davide-baldo davide-baldo force-pushed the reduce-health-check-noise branch 2 times, most recently from e3eab17 to dcc38fb Compare July 14, 2025 15:14
@davide-baldo
Copy link
Contributor Author

rebased

@davide-baldo davide-baldo force-pushed the reduce-health-check-noise branch from dcc38fb to 9f29381 Compare August 4, 2025 12:25
@davide-baldo davide-baldo force-pushed the reduce-health-check-noise branch from 9f29381 to 8d7a2f4 Compare August 4, 2025 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/api http Affects the HTTP Gateway API area/cli Affects the command line area/tooling Affects the dev or user toolchain (e.g. tests, ci, build tools)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants