-
Notifications
You must be signed in to change notification settings - Fork 337
Added a flag to disable tracing of health check requests #2494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
I have read the CLA Document and I hereby sign the CLA |
18d055f
to
e66d682
Compare
Codecov Report❌ Patch coverage is
❌ Your project check has failed because the head coverage (39.45%) is below the target coverage (75.00%). You can increase the head coverage or adjust the target coverage.
Additional details and impacted files@@ Coverage Diff @@
## main #2494 +/- ##
===========================================
- Coverage 77.43% 39.45% -37.97%
===========================================
Files 417 376 -41
Lines 51071 47129 -3942
===========================================
- Hits 39541 18592 -20949
- Misses 9038 26977 +17939
+ Partials 2492 1560 -932 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
e3eab17
to
dcc38fb
Compare
rebased |
dcc38fb
to
9f29381
Compare
9f29381
to
8d7a2f4
Compare
Added the option
--otel-disable-healthcheck-tracing
to disable health-check requests for both HTTP and GRPC requests.This PR addresses the issue Allow disabling health check traces
I'm not used to writing Go, so please let me know if there is anything I can do to improve the code or make it more idiomatic.
I've also manually validated the result using a locally deployed Jaeger.