add tests for health check service #2468
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
area/tooling
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2468 +/- ##
==========================================
- Coverage 77.35% 77.33% -0.01%
==========================================
Files 414 414
Lines 50712 50713 +1
==========================================
- Hits 39224 39215 -9
- Misses 9016 9022 +6
- Partials 2472 2476 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
miparnisari
reviewed
Jun 25, 2025
| @@ -108,6 +108,7 @@ func (hm *healthManager) checkIsReady(ctx context.Context) bool { | |||
| dsReady, err := hm.dsc.ReadyState(ctx) | |||
| if err != nil { | |||
| log.Ctx(ctx).Warn().Err(err).Msg("could not check if the datastore was ready") | |||
| return false | |||
There was a problem hiding this comment.
This change makes sense to me, but why aren't we doing both checks in parallel? Say the datastore takes forever to respond, but the dispatcher already errored out, we will be waiting datastoreReadyTimeout when we could have returned "false" very quickly.
It also seems to me that (hm *healthManager) Checker can be simplified by using backoff.Timer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wrote these tests because I suspected a bug here, but it looks like it was fine. The extra coverage doesn't hurt, though.