remove timestamp from generated files

[katexochen]

This enables reproducible OS builds.
Fixes #319

This is an alternative approach to #348, based on the suggestion by @cgwalters

[travier]

+1 from me for this PR as well. (not a maintainer either but an interested party like Colin).

[pbrezina]

Hi, so I finally have some time to put into authselect. Thank you for the contribution.

Do I understand it correctly that there are two distinct solutions and that we merge only one? That is:

• do not write timestamp into the generated files (this PR)
• write timestamp from the SOURCE_DATE_EPOCH support SOURCE_DATE_EPOCH as timesource #348

[katexochen]

Do I understand it correctly that there are two distinct solutions and that we merge only one? That is:

• do not write timestamp into the generated files (this PR)
• write timestamp from the SOURCE_DATE_EPOCH support SOURCE_DATE_EPOCH as timesource #348

@pbrezina exactly, and I'd say that this PR here is the preferred solution. :)

[pbrezina]

Yes, I agree. I don't think there is any particular reason to keep the timestamp in the preamble.

I would just like to keep template_generate_preamble and only remove the timestamp parameter.

[pbrezina]

Also is Fedora rawhide enough or do you want to deliver this also to F39 or older?

[travier]

F39 would be nice

[katexochen]

I would just like to keep template_generate_preamble and only remove the timestamp parameter.

Done.

[katexochen]

Also is Fedora rawhide enough or do you want to deliver this also to F39 or older?

F38 would be great.

[pbrezina]

Please, apply this diff and we can merge:

diff --git a/src/lib/util/template.c b/src/lib/util/template.c
index 98d762e..f211d86 100644
--- a/src/lib/util/template.c
+++ b/src/lib/util/template.c
@@ -555,7 +555,8 @@ template_generate_preamble()
         "# Do not modify this file manually, use authselect instead. Any user changes will be overwritten.\n"
         "# You can stop authselect from managing your configuration by calling 'authselect opt-out'.\n"
         "# See authselect(8) for more details.\n\n";
-    return preamble;
+
+    return strdup(preamble);
 }
 
 errno_t
@@ -668,15 +669,18 @@ template_write(const char *filepath,
                const char *content,
                mode_t mode)
 {
-    const char *preamble = template_generate_preamble();
+    char *preamble;
     char *output;
     errno_t ret;
 
+    preamble = template_generate_preamble();
     if (content == NULL) {
-        output = strdup(preamble);
+        output = preamble;
     } else {
         output = format("%s%s", preamble, content);
+        free(preamble);
     }
+
     if (output == NULL) {
         return ENOMEM;
     }

Also the commit message should look like this:

    templates: remove timestamp from generated files

    This enables reproducible OS builds.

    Resolves: https://github.com/authselect/authselect/issues/319

    Co-authored-by: Malte Poll <[email protected]>
    Signed-off-by: Paul Meyer <[email protected]>

Thank you.

[pbrezina]

Thank you.

[pbrezina]

F38: https://bodhi.fedoraproject.org/updates/FEDORA-2023-c513a6e7c1
F39: https://bodhi.fedoraproject.org/updates/FEDORA-2023-5f22e99282
rawhide: https://bodhi.fedoraproject.org/updates/FEDORA-2023-324d404fe9