Skip to content

Conversation

@JohnRoesler
Copy link

🔧 Changes

Small documentation consistency change to the attack_protection shields lists

📚 References

🔬 Testing

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@JohnRoesler JohnRoesler requested a review from a team as a code owner October 10, 2025 19:13
@JohnRoesler
Copy link
Author

@kushalshit27 please review

@duedares-rvj
Copy link
Member

@JohnRoesler Hello 👋
Could you briefly explain what's incorrect in the current example file?

pre_user_registration {
      shields = ["block"]    
    }
    pre_change_password {
      shields = ["block", "admin_notification"]
    }

Also, for docs update:

  1. Make your change here:
  2. Run make docs

This shall do the same thing, but make docs shall help your changes not get reverted.
It also takes care of schema changes, descriptions etc.

Thanks

@JohnRoesler
Copy link
Author

@duedares-rvj just listing all the options and in the same order in the docs 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants