Ability to decode from dec/hex string #127
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you. This looks good. I guess we can get rid of the old encoder logic and make this a breaking change with a new major release. But for now we could keep this as a compatibility layer. Maybe we can put the decoder behind a SwiftSetting: https://docs.swift.org/package-manager/PackageDescription/PackageDescription.html#swiftsetting |
|
@tgymnich can you please make a new release? |
|
@bogdan version 5.6 has been tagged and there is a pre release. Is something missing? Will change the pre release to a proper release soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current encoding/decoding mechanism is only useful when swift is storing data locally in JSON, no other platform would recognize encoding/decoding into an array of words with sign being the first element.
This patch allows a more standard decoding from HEX or DEC string only in decoding.
It leaves encoding intact due to backward compatibility.
Fixes #126.