Skip to content

BUG: reference the FED calendar correctly. (#144) #1065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 24, 2025
Merged

BUG: reference the FED calendar correctly. (#144) #1065

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions python/tests/scheduling/test_calendars.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -668,3 +668,8 @@ def test_next_imm_depr():
def test_get_imm_depr():
with pytest.warns(DeprecationWarning):
get_imm(3, 2000, definition="imm")


def test_fed_nyc_good_friday():
assert not get_calendar("nyc").is_bus_day(dt(2024, 3, 29))
assert get_calendar("fed").is_bus_day(dt(2024, 3, 29))
7 changes: 4 additions & 3 deletions rust/scheduling/calendars/named/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,12 @@
//! Static data for pre-existing named holiday calendars.
//!

Check warning on line 3 in rust/scheduling/calendars/named/mod.rs

View workflow job for this annotation

GitHub Actions / build (3.13) 

Diff in /home/runner/work/rateslib/rateslib/rust/scheduling/calendars/named/mod.rs
pub mod all;
pub mod bus;
pub mod ldn;
pub mod mum;
pub mod nyc;
pub mod fed;

Check warning on line 9 in rust/scheduling/calendars/named/mod.rs

View workflow job for this annotation

GitHub Actions / build (3.13) 

Diff in /home/runner/work/rateslib/rateslib/rust/scheduling/calendars/named/mod.rs
pub mod osl;
pub mod stk;
pub mod syd;
Expand All @@ -25,7 +26,7 @@
("all", all::WEEKMASK),
("bus", bus::WEEKMASK),
("nyc", nyc::WEEKMASK),
("fed", nyc::WEEKMASK),
("fed", fed::WEEKMASK),
("tgt", tgt::WEEKMASK),
("ldn", ldn::WEEKMASK),
("stk", stk::WEEKMASK),
Expand All @@ -51,7 +52,7 @@
("all", all::HOLIDAYS),
("bus", bus::HOLIDAYS),
("nyc", nyc::HOLIDAYS),
("fed", nyc::HOLIDAYS),
("fed", fed::HOLIDAYS),
("tgt", tgt::HOLIDAYS),
("ldn", ldn::HOLIDAYS),
("stk", stk::HOLIDAYS),
Expand Down Expand Up @@ -80,7 +81,7 @@
// ("all", all::RULES),
// ("bus", bus::RULES),
// ("nyc", nyc::RULES),
// ("fed", nyc::RULES),
// ("fed", fed::RULES),
// ("tgt", tgt::RULES),
// ("ldn", ldn::RULES),
// ("stk", stk::RULES),
Expand Down
Loading