This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Open pending file on right arrow #712
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuychaco
added a commit
that referenced
this pull request
Jan 27, 2016
Open pending file on right arrow
This was referenced Jan 27, 2016
Contributor
Author
|
I prematurely merged this PR before the Travis build passed because the PR page didn't indicate that a build was in progress. I only saw a green checkmark and falsely believed that I was good to go with my merge. Soon after I received an email from Travis about a broken build. Note that it takes a while before the Travis status is displayed on the PR page. I took some screenshots of this during a subsequent pull request #714 I made for this feature: Upon making the pull request this is what is displayed:
30 seconds later Travis status showed up:Looks like it might show up only once the build has actually started... This build passed 🎉(originally the specs I wrote weren't backwards compatible with the current release of Atom core) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #413