Remove DS_Store from gitignore

[elifoster]

DS_Store belongs in the user's global gitignore file, rather than the project gitignore.

(This was taken from my previous issue, which was in the wrong location at package-generator)

The default .gitignore file includes .DS_Store. According to GitHub and most people, this should be in the user's global gitignore rather than project gitignores.

Sources:

• Added OS X Specific .DS_Store ignore github/gitignore#1638
• Added DS_Store github/gitignore#1591
• Update gitignore to exculde Mac DS_Store file github/gitignore#1458
• Add DS_Store github/gitignore#1256
• Great help for developers on the Mac github/gitignore#1381
• add a ignore item -> .DS_Store github/gitignore#1155
• and a search for all DS_Store related things in the gitignore repo
• and a blog post about this

[shiftkey]

👍

[elifoster]

Any word on merging this PR? It's been over 2 weeks since I opened it.

[kevinsawicki]

Any word on merging this PR? It's been over 2 weeks since I opened it.

Apologies for the delay.

Is there a downside to having it in this project's .gitignore file?

Having it here ensures that any pull requests created won't add those files back in the case where the author doesn't have this in their global ignore right?

Many many repos in the Atom org. have it in their .gitignore files so I'm just wondering what we should do elsewhere. https://github.com/atom/atom/blob/e58ea27e911e306bc358c90dfb23876ca9c9330f/.gitignore#L3

[elifoster]

Is there a downside to having it in this project's .gitignore file?

It appears as messy, and promotes poor system set up. Additionally, GitHub's default gitignores don't include system files in the first place, since these files should be in the global gitignore.

Having it here ensures that any pull requests created won't add those files back in the case where the author doesn't have this in their global ignore right?

Yes, however people should know what each file in their pull request is for. Otherwise, that's just sloppy.

Many many repos in the Atom org. have it in their .gitignore files so I'm just wondering what we should do elsewhere. https://github.com/atom/atom/blob/e58ea27e911e306bc358c90dfb23876ca9c9330f/.gitignore#L3

I was under the impression that this gitignore was also what gets created when running the package. Is this true? If so, that's why I only submitted a PR here, since users should be utilizing the great global gitignore. Honestly, Atom should eliminate all the DS_Stores from all the gitignores, but that's not my call to make, and I can't really say I have the time to submit hundreds of PRs just for that.

Also, if you are going to keep DS_Store, why include OSX system files but not system files for any other systems, like Thumbs.db?