Added temporary tabs

[carlosingles]

Introduces new setting that opens all tabs in a temp state, allowing them to be closed when focus is changed from item to item.

Origin: ddavison/sublime-tabs#43

[lee-dohm]

/cc @atom/feedback

[carlosingles]

Sorry added an extra commit, forgot that Sublime Text keeps the file open if it has been modified.

[benogle]

Multiple commits is totally fine. We never squash.

[winstliu]

This is misleading considering that the tabs stay open once they're modified. Perhaps Tabs will only stay open if they are modified or double-clicked or Tabs with no changes are closed once they lose focus unless they are double-clicked.

[winstliu]

Also, some specs would be nice for this 😄.

[thomasjo]

Also, some specs would be nice for this

I'm gonna be a little bit stricter; specs for this is mandatory.

[thomasjo]

I don't really like the name temporaryTabs. We're in the context of "tabs" already, so maybe it should be something along the lines of temporaryMode, useTransientBehavior, transience, or some such.

Naming stuff is difficult.

[carlosingles]

Thanks for the help guys 😃

I've implemented your suggestions and renamed the setting to "useTransientBehaviour" - seems to make the most sense

I also modified the code to prevent TextEditor tabs from being closed when any other panel is opened and focused

I'll work on writing some specs next 👍

[carlosingles]

I'm not extremely familiar with writing specs, so forgive me if they're completely wrong 🙈

Any tips / help appreciated if I missed anything!

[ddavison]

use specs from sublime-tabs.. since this PR is based on that, you should be able to see which tests test which behavior and try accordingly

[carlosingles]

Thanks 👍

I've updated the specs to use the specs from sublime-tabs and have also updated them to suit this fork.

Also I removed the case for Images since my fork is only testing for TextEditors, I'm not sure what the preferred behaviour would be for images - for me it makes more sense that images open in non-transient tabs.

[roman01la]

👍

[acontreras89]

👍

[dioxmio]

Nice work 👍