This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Bust file's digest cache when writing to the file #85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Contributor
There was a problem hiding this comment.
Isn't Atom transitioning to native promises now? Or is that just for Atom packages and not Node ones?
Contributor
Author
There was a problem hiding this comment.
It's node modules too; in fact, on the master branch of this repo (and for versions >= 5), we're no longer using Q. Once we upgrade electron, we will be able to stop using Q in Atom, and upgrade it to use a newer pathwatcher version. This PR is against an older version though, in which we haven't yet removed Q.
Contributor
There was a problem hiding this comment.
Ah, gotcha. Didn't realize this was on an old version of pathwatcher.
maxbrunsfeld
pushed a commit
that referenced
this pull request
Sep 15, 2015
Bust file's digest cache when writing to the file
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs atom/text-buffer#97