Safely cast params

[Aerijo]

Requirements for Contributing a Bug Fix

• Fill out the template below. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
• The pull request must only fix an existing bug. To contribute other changes, you must use a different template. You can see all templates at https://github.com/atom/.github/tree/master/.github/PULL_REQUEST_TEMPLATE.
• The pull request must update the test suite to demonstrate the changed functionality. For guidance, please see https://flight-manual.atom.io/hacking-atom/sections/writing-specs/.
• After you create the pull request, all status checks must be pass before a maintainer reviews your contribution. For more details, please see https://github.com/atom/.github/tree/master/CONTRIBUTING.md#pull-requests.

Identify the Bug

Tests raise fatal error when native code is built and run in debug mode.

Description of the Change

Changes the value casts to be safer. The original Local<Object>::Cast is basically a no-op in release mode, but has an assertion in debug mode (see this). Therefore, when it is running in debug mode and a non-object is passed, it errored. The change moves the cast after checking if it was a string, instead of casting and then checking what it was.

Alternate Designs

na

Possible Drawbacks

na

Verification Process

The tests pass (with both release and debug builds).

Release Notes

• Reorder JS to native variable type casts