This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Fix engines field in package.json #267
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Oh weird that * was an error. |
Contributor
|
@benogle can you help me understand why we would want an upper bound to this? The |
Contributor
Author
|
This supports only the atom 1.0 api. It's future proofing for 2.0. We can set it and forget it. |
benogle
added a commit
that referenced
this pull request
Feb 19, 2015
Fix engines field in package.json
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
*to reduce confusion, and add make sure atom is less than2.0.0.