Skip to content

Conversation

@Blacksmoke16
Copy link
Member

@Blacksmoke16 Blacksmoke16 commented Jun 23, 2024

Context

Resolves #128

NOTE: From this point on, if a component wants to rescue any exception it MUST use ::Exception to avoid conflicting with the new Exception component namespace.

Once Crystal 1.13 is officially released, we can bump min required version and remove the manual exception type checks.

Changelog

  • Breaking: Rename namespace exceptions live in to Exception from Exceptions
  • Breaking: Parent type of some exception types have changed
    • May result in it not being rescued if the rescue was on the parent type and not the exception type itself
  • Breaking: Rename RuntimeError console exception type to Runtime
  • Breaking: Remove ACON::Exceptions::ConsoleException
  • Breaking: Remove ACON::Exceptions::ValidationFailed
  • Breaking: Remove Athena::Negotiation::Exceptions::Negotiation
  • Breaking: Remove Athena::Serializer::Exceptions::SerializerException
  • Breaking: Remove Athena::Validator::Exceptions::ValidatorError
  • Bump minimum Crystal version to 1.13 for console, mercure, negotiation, and serializer components

@Blacksmoke16 Blacksmoke16 added component:ecosystem Affects all components in the ecosystem kind:enhancement New functionality to an existing feature breaking labels Jun 23, 2024
@Blacksmoke16 Blacksmoke16 marked this pull request as ready for review August 23, 2024 18:31
@Blacksmoke16 Blacksmoke16 merged commit b09a847 into master Aug 23, 2024
@Blacksmoke16 Blacksmoke16 deleted the exception-refactor branch August 23, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

Normalize exception types

2 participants