Skip to content

Make members for matches not-nullable #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

pavog
Copy link
Member

@pavog pavog commented Aug 6, 2025

All these member variables are always set in setMatches().
This means that they can never be null and are not used before set.
We can therefore be sure that they are not nullable and change the types accordingly.

@pavog pavog requested review from JulianVennen and matthi4s August 6, 2025 15:45
Copy link
Member

@JulianVennen JulianVennen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having unset properties in PHP is generally not a good idea

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants