Skip to content

Conversation

at-wat
Copy link
Owner

@at-wat at-wat commented Feb 25, 2021

Taking over #129

@at-wat at-wat self-assigned this Feb 25, 2021
@codecov
Copy link

codecov bot commented Feb 25, 2021

Codecov Report

Merging #150 (9f4c708) into master (d967435) will increase coverage by 0.06%.
The diff coverage is 96.58%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #150      +/-   ##
==========================================
+ Coverage   99.15%   99.21%   +0.06%     
==========================================
  Files          23       24       +1     
  Lines        1308     1409     +101     
==========================================
+ Hits         1297     1398     +101     
  Misses          6        6              
  Partials        5        5              
Impacted Files Coverage Δ
mkvcore/blockwriter.go 98.37% <50.00%> (-0.02%) ⬇️
mkvcore/blockreader.go 97.61% <97.61%> (ø)
mkvcore/option.go 100.00% <100.00%> (ø)
unmarshal.go 100.00% <100.00%> (+1.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d967435...9f4c708. Read the comment docs.

@at-wat at-wat marked this pull request as ready for review February 27, 2021 00:48
@at-wat at-wat changed the title Implement block reader Implement SimpleBlockReader Feb 27, 2021
@at-wat at-wat merged commit fda12f1 into master Feb 27, 2021
@at-wat at-wat deleted the implement-block-reader branch February 27, 2021 03:13
This was referenced Feb 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants