Skip to content

Support parsing damaged mkv #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 17, 2021
Merged

Support parsing damaged mkv #147

merged 3 commits into from
Feb 17, 2021

Conversation

at-wat
Copy link
Owner

@at-wat at-wat commented Feb 16, 2021

fix #146

master branch

BenchmarkUnmarshal-32   2984522   2009 ns/op   328 B/op   41 allocs/op

this PR 18c1df0

BenchmarkUnmarshal-32   2466994   2431 ns/op   360 B/op   43 allocs/op

c66164e

BenchmarkUnmarshal-32   2302615   2602 ns/op   504 B/op   47 allocs/op

@at-wat at-wat self-assigned this Feb 16, 2021
@codecov
Copy link

codecov bot commented Feb 16, 2021

Codecov Report

Merging #147 (fd5e125) into master (1d0de7b) will increase coverage by 0.25%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #147      +/-   ##
==========================================
+ Coverage   98.96%   99.22%   +0.25%     
==========================================
  Files          22       23       +1     
  Lines        1262     1291      +29     
==========================================
+ Hits         1249     1281      +32     
+ Misses          7        5       -2     
+ Partials        6        5       -1     
Impacted Files Coverage Δ
block.go 100.00% <100.00%> (ø)
reader.go 100.00% <100.00%> (ø)
unlacer.go 100.00% <100.00%> (+2.32%) ⬆️
unmarshal.go 98.83% <100.00%> (+0.71%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d0de7b...fd5e125. Read the comment docs.

@at-wat at-wat marked this pull request as ready for review February 17, 2021 02:23
@at-wat
Copy link
Owner Author

at-wat commented Feb 17, 2021

Using bench data: #148

master

BenchmarkUnmarshal-32   611911   9060 ns/op   2844 B/op   171 allocs/op

this PR

BenchmarkUnmarshal-32   529870   10677 ns/op   2951 B/op   176 allocs/op

@at-wat at-wat merged commit f769d2b into master Feb 17, 2021
@at-wat at-wat deleted the support-parsing-damaged-mkv branch February 17, 2021 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support reading damaged mkv
1 participant