[SIMBAD] fix: remove pm from the list of fields - bug introduced in #3186 #3259
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ManonMarchand
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3259 +/- ##
=======================================
Coverage 69.09% 69.09%
=======================================
Files 232 232
Lines 19637 19637
=======================================
Hits 13568 13568
Misses 6069 6069 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bsipocz
force-pushed
the
fix-remove-pm-field
branch
from
0af127a to
8904953
Compare
bsipocz
approved these changes
Mar 17, 2025
There was a problem hiding this comment.
There was a failing doctest (it only shows with remote testing), it was quicker to push a fix for it than raise it in review.
The rest look good. Thanks!
(I also rebased it so the fixes from your other PR is being included rather than raising unrelated test failures)
|
Thank you, sorry for the failing doctest! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #3240
The wrong field got introduced in version 0.4.9 in PR #3186