Skip to content

Conversation

ManonMarchand
Copy link
Member

@ManonMarchand ManonMarchand commented Feb 24, 2025

Hi astroquery's devs 🙂

An abusive XMatch user with astroquery's user agent was banned from our servers today. This made me realize that there are no warnings nor explanations in the documentation about DDoS attacks in this module.

Our support email is also added to the error message and to the documentation so that we can un-ban the astronomers after helping improving their workflows.

The section in the documentation can be removed when there will be a new release, as people won't see the 403: Forbidden error anymore.

Copy link

codecov bot commented Feb 24, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 68.69%. Comparing base (311197b) to head (b356dfe).
Report is 326 commits behind head on main.

Files with missing lines Patch % Lines
astroquery/xmatch/core.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3225      +/-   ##
==========================================
- Coverage   68.69%   68.69%   -0.01%     
==========================================
  Files         231      231              
  Lines       19214    19216       +2     
==========================================
+ Hits        13199    13200       +1     
- Misses       6015     6016       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ManonMarchand ManonMarchand marked this pull request as draft February 24, 2025 16:45
@bsipocz bsipocz added this to the v0.4.10 milestone Feb 24, 2025
Copy link
Member

@bsipocz bsipocz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor wordsmithing, but otherwise looks all good. Thanks!

@ManonMarchand ManonMarchand marked this pull request as ready for review February 25, 2025 10:25
@ManonMarchand
Copy link
Member Author

This is ready for merging, I applied your language corrections and asked XMatch's maintainer to validate the message 🙂

Co-authored-by: Adam Ginsburg <[email protected]>
@bsipocz bsipocz merged commit 8e62857 into astropy:main Feb 25, 2025
9 of 10 checks passed
@bsipocz
Copy link
Member

bsipocz commented Feb 25, 2025

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants