Skip to content

Conversation

keflavich
Copy link
Contributor

This PR moves the test data to filenames that match what's actually used in the query. It fixes #3007.

@bsipocz
Copy link
Member

bsipocz commented Feb 11, 2025

CI failures are related

Copy link

codecov bot commented Feb 11, 2025

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 68.34%. Comparing base (3e9ff61) to head (250cd59).
Report is 333 commits behind head on main.

Files with missing lines Patch % Lines
astroquery/linelists/cdms/core.py 50.00% 1 Missing ⚠️
astroquery/linelists/cdms/setup_package.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3202      +/-   ##
==========================================
- Coverage   68.34%   68.34%   -0.01%     
==========================================
  Files         231      231              
  Lines       19190    19192       +2     
==========================================
+ Hits        13116    13117       +1     
- Misses       6074     6075       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@bsipocz bsipocz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now this all looks good. Thanks!

@bsipocz bsipocz merged commit d619223 into astropy:main Feb 12, 2025
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TST BUG: cdms mocked example raises EmptyResponseError
2 participants