Skip to content

Conversation

SultanOrazbayev
Copy link
Contributor

@SultanOrazbayev SultanOrazbayev commented Mar 3, 2024

A small fix for the PyPI badge and added conda-forge badge.

Update: I tried and failed to add the labels. Hope this is OK.

@bsipocz
Copy link
Member

bsipocz commented Mar 6, 2024

Please don't add a conda-forge badge as our official release is pypi or maybe github, but definitely not conda-forge.
But the pypi badge is indeed broken, so once this PR is squashed back to one commit that fixes the pypi badge we can merge it.

@SultanOrazbayev
Copy link
Contributor Author

Thank you for the quick feedback! I removed conda-forge... if I understand correctly, squashing is done by the merger (so on your end)?

Copy link

codecov bot commented Mar 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.80%. Comparing base (4d23117) to head (48bb308).
Report is 2 commits behind head on main.

❗ Current head 48bb308 differs from pull request most recent head 89884a7. Consider uploading reports for the commit 89884a7 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2961   +/-   ##
=======================================
  Coverage   66.80%   66.80%           
=======================================
  Files         237      237           
  Lines       18321    18321           
=======================================
  Hits        12239    12239           
  Misses       6082     6082           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bsipocz bsipocz force-pushed the path-readme-shield branch from 0a49f3b to 48bb308 Compare March 6, 2024 16:00
@bsipocz
Copy link
Member

bsipocz commented Mar 6, 2024

if I understand correctly, squashing is done by the merger (so on your end)?

Yes, I can do that. I've also fixed the link target of the badge.

@bsipocz bsipocz added this to the v0.4.7 milestone Mar 6, 2024
@bsipocz bsipocz force-pushed the path-readme-shield branch from 48bb308 to 89884a7 Compare March 6, 2024 16:04
@bsipocz
Copy link
Member

bsipocz commented Mar 6, 2024

(btw, we do have a lot of dev versions pushed to pypi, but unfortunately I didn't find a way to show those version numbers in the badge, therefore I linked to the version history page rather than the main pypi one)

@bsipocz bsipocz merged commit a68643c into astropy:main Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants