CI: force to pick up dev versions for devdeps #2906
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
converting to draft as there is still something wrong going on with the ogle part. Oh, well, I see that it's broken anyway (#2805), but still, my patch here doesn't make the situation better, but has instead obscured it a tiny bit further. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2906 +/- ##
==========================================
- Coverage 67.08% 66.59% -0.49%
==========================================
Files 235 235
Lines 18135 18131 -4
==========================================
- Hits 12166 12075 -91
- Misses 5969 6056 +87 ☔ View full report in Codecov by Sentry. |
|
I'm going ahead and merge this one, the ogle module is not more broken than before and we should either fix or decommission it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently, we haven't been testing with npdev even though the config suggests we do.
A long-term solution would be to make a version checker and make these jobs fail when a required version is being downgraded by another dependency...
Locally, I see a couple of issues, so more commits to come for this PR.