Skip to content

Conversation

mkelley
Copy link
Contributor

@mkelley mkelley commented Aug 1, 2023

JPL Horizons has had a few additions to their columns. Update astroquery to match. Based on the Horizons documentation, the new quantities are:

       44. Apparent target-centered longitude of Sun (L_s)
     * 45. Inertial frame apparent RA & DEC
       46.   Rates: Inertial RA & DEC
     * 47. Sky motion: angular rate & angles
       48. Lunar sky brightness & target visual SNR

Also add units to hour_angle, solartime, and siderealtime. (bugfix)

Addresses issue #2783

@codecov
Copy link

codecov bot commented Aug 1, 2023

Codecov Report

Merging #2794 (8131bad) into main (fa181fa) will increase coverage by 0.00%.
Report is 4 commits behind head on main.
The diff coverage is n/a.

❗ Current head 8131bad differs from pull request most recent head a3d52ad. Consider uploading reports for the commit a3d52ad to get more accurate results

@@           Coverage Diff           @@
##             main    #2794   +/-   ##
=======================================
  Coverage   66.11%   66.12%           
=======================================
  Files         235      235           
  Lines       18077    18080    +3     
=======================================
+ Hits        11952    11955    +3     
  Misses       6125     6125           
Files Changed Coverage Δ
astroquery/jplhorizons/__init__.py 100.00% <ø> (ø)
astroquery/jplhorizons/core.py 65.49% <ø> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@bsipocz bsipocz added this to the v0.4.7 milestone Aug 1, 2023
@bsipocz
Copy link
Member

bsipocz commented Aug 1, 2023

Thanks @mkelley!

@bsipocz
Copy link
Member

bsipocz commented Aug 1, 2023

Not sure what went wrong here that bloated up the diff this badly. Could you maybe rebase and remove that second to last commit that only added noise by reformatting, but haven't really fixed the whitespace issue?

@mkelley
Copy link
Contributor Author

mkelley commented Aug 1, 2023

Shucks, I had worked so hard to keep black from reformatting the file... but missed it one time.

@bsipocz bsipocz force-pushed the jplhorizons-updated-columns-2023.08 branch from 8131bad to a3d52ad Compare August 1, 2023 19:27
Copy link
Member

@bsipocz bsipocz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good! Thanks @mkelley!

@bsipocz bsipocz merged commit e492b9b into astropy:main Aug 1, 2023
@mkelley mkelley deleted the jplhorizons-updated-columns-2023.08 branch August 1, 2023 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Horizons: Getting Sky_motion and Sky_mot_PA columns in obj.ephemerides() request
2 participants