-
-
Notifications
You must be signed in to change notification settings - Fork 423
Update jplhorizons columns #2794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update jplhorizons columns #2794
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2794 +/- ##
=======================================
Coverage 66.11% 66.12%
=======================================
Files 235 235
Lines 18077 18080 +3
=======================================
+ Hits 11952 11955 +3
Misses 6125 6125
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Thanks @mkelley! |
Not sure what went wrong here that bloated up the diff this badly. Could you maybe rebase and remove that second to last commit that only added noise by reformatting, but haven't really fixed the whitespace issue? |
Shucks, I had worked so hard to keep black from reformatting the file... but missed it one time. |
8131bad
to
a3d52ad
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks good! Thanks @mkelley!
JPL Horizons has had a few additions to their columns. Update astroquery to match. Based on the Horizons documentation, the new quantities are:
Also add units to
hour_angle
,solartime
, andsiderealtime
. (bugfix)Addresses issue #2783