Fixing code coverage #2674
Merged
Fixing code coverage #2674
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jaymedina Can you take a look at this? |
Codecov Report
@@ Coverage Diff @@
## main #2674 +/- ##
==========================================
+ Coverage 69.16% 69.19% +0.02%
==========================================
Files 304 304
Lines 22539 22539
==========================================
+ Hits 15589 15595 +6
+ Misses 6950 6944 -6
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Yep! Will do that this sprint, probably this week @ceb8 |
bsipocz
approved these changes
Feb 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I acccidentall dropped the code coverage below allowed levels for the repo when I merged #2668 (mixed up patch vs project failure).
This PR adds tests for the
InvalidQueryErrorexceptions in that PR and bumps the coverage back up to acceptable levels.