Skip to content

Conversation

javier-ballester
Copy link
Contributor

Dear Astroquery,

The RMF to be used for the spectral analysis should be generated with the same PPS version as the spectrum, background and ARF. The PPS version can be found in SASVERS keyword in the SPECTRUM file, characters [-6:-3]. Once the sas version is determined, the code should look for the proper version of RMF in the FTP tree. However, for the current PPS versions available in the archive, i.e v18.0,v19.0 and v20.0, all RMF matrices are equal among the versions and for all instruments, so it is possible to download the last one, v20.0, available in the root FTP stored in 'rmf_ftp'. In the future, the FTP tree and/or PPS keywords will be modified to make easier to download the appropriate RMF file for each spectrum.

At the moment the version for the RMF matrices is v20.0 so the link to the proper file does not work. Therefore we need this quick patch to get the links to work again.

Kind regards,

Xmm_newton team

@codecov
Copy link

codecov bot commented Jul 22, 2022

Codecov Report

Merging #2472 (a2cfab8) into main (74fb75d) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main    #2472   +/-   ##
=======================================
  Coverage   62.92%   62.92%           
=======================================
  Files         133      133           
  Lines       17302    17302           
=======================================
  Hits        10888    10888           
  Misses       6414     6414           
Impacted Files Coverage Δ
astroquery/esa/xmm_newton/core.py 64.45% <0.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@javier-ballester javier-ballester marked this pull request as ready for review July 22, 2022 15:30
@bsipocz bsipocz added this to the v0.4.7 milestone Jul 22, 2022
@bsipocz bsipocz merged commit 8cd3295 into astropy:main Jul 22, 2022
@bsipocz
Copy link
Member

bsipocz commented Jul 22, 2022

Thanks @javier-ballester!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants