Skip to content

Conversation

bsipocz
Copy link
Member

@bsipocz bsipocz commented Feb 25, 2022

This was a minor bug added in #2246, the lesson to learn is to run the remote tests before merging a PR.

_________________________________________________________________________________________________________________ test_download_html_file __________________________________________________________________________________________________________________

    @pytest.mark.remote_data
    def test_download_html_file():
>       result = alma.download_files(['https://almascience.nao.ac.jp/dataPortal/member.uid___A001_X1284_X1353.qa2_report.html'])
E       AttributeError: 'function' object has no attribute 'download_files'

astroquery/alma/tests/test_alma_remote.py:656: AttributeError

@bsipocz
Copy link
Member Author

bsipocz commented Feb 25, 2022

There are a few remaining remote data test failures, some of which looks real, if you, @keflavich or @andamian could look at them separately it would be superb:

FAILED astroquery/alma/tests/test_alma_remote.py::TestAlma::test_freq - pyvo.dal.exceptions.DALFormatError: ProtocolError: ('Connection broken:...
FAILED astroquery/alma/tests/test_alma_remote.py::TestAlma::test_data_info - FileNotFoundError: [Errno 2] No such file or directory: '/var/fold...
FAILED astroquery/alma/tests/test_alma_remote.py::TestAlma::test_download_data - AssertionError: assert 0 == 2
FAILED astroquery/alma/tests/test_alma_remote.py::TestAlma::test_download_and_extract - assert 0 > 1

@codecov
Copy link

codecov bot commented Feb 25, 2022

Codecov Report

Merging #2310 (248ff4d) into main (6834ef9) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2310   +/-   ##
=======================================
  Coverage   63.08%   63.08%           
=======================================
  Files         131      131           
  Lines       17005    17005           
=======================================
  Hits        10728    10728           
  Misses       6277     6277           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6834ef9...248ff4d. Read the comment docs.

@bsipocz bsipocz merged commit d2d3b21 into astropy:main Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant