Convert FixedTargets passed to get_body into SkyCoords
#568
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmorris3
force-pushed
the
fix-issue-567
branch
from
8260855 to
1851314
Compare
bmorris3
force-pushed
the
fix-issue-567
branch
from
1851314 to
158b72a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@pmaxted reported in #567 that when a (list of)
FixedTargetis passed to methods that calculate lunar coordinates, the calls toget_bodyintroduced in #558 must convert thoseFixedTargets toSkyCoordsbefore computing separations. This oversight wasn't noticed in the tests because the relevant tests rely on SkyCoords.This PR calls
get_skycoordsbefore passing thetargetstoget_body.Fixes #567