Skip to content

Conversation

charliermarsh
Copy link
Member

Summary

This is now consistent with requires_dist (singular).

@charliermarsh charliermarsh added the internal A refactor or improvement that is not user-facing label Sep 13, 2025
@charliermarsh charliermarsh marked this pull request as ready for review September 13, 2025 02:52
requires_dist: metadata.requires_dist,
requires_python: metadata.requires_python,
provides_extras: metadata.provides_extras,
provides_extra: metadata.provides_extras,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we rename metadata.provides_extra too?

@charliermarsh
Copy link
Member Author

@konstin -- Do you mind skimming again? I had to change this on a bunch of other structs once I followed the thread from your comment.

@konstin
Copy link
Member

konstin commented Sep 14, 2025

Thanks, I renamed the tiny remaining items.

@konstin
Copy link
Member

konstin commented Sep 14, 2025

I think the PR is ready to go as-is.

Since we're already bumping the cache version, we should decide before the next release whether we also want to change package.metadata.provides-extras in uv.lock to package.metadata.provides-extra (minor version bump) and provides-extras in tool.uv.dependency-metadata to provides-extra. The latter would happen without dropping support for the provides-extras alias, we only need to update the docs to recommend the singular term. I'd do those in follow-up PRs for size and release notes.

@charliermarsh
Copy link
Member Author

I think I did change tool.uv.dependency-metadata to use provides-extra so let me just update the docs there (without removing the alias).

@charliermarsh charliermarsh enabled auto-merge (squash) September 14, 2025 13:26
@charliermarsh charliermarsh merged commit b770639 into main Sep 14, 2025
98 checks passed
@charliermarsh charliermarsh deleted the charlie/provides branch September 14, 2025 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal A refactor or improvement that is not user-facing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants