-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Rename provides_extras
to provides_extra
#15825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
requires_dist: metadata.requires_dist, | ||
requires_python: metadata.requires_python, | ||
provides_extras: metadata.provides_extras, | ||
provides_extra: metadata.provides_extras, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we rename metadata.provides_extra
too?
4ed4181
to
89d22a1
Compare
89d22a1
to
ee025ba
Compare
@konstin -- Do you mind skimming again? I had to change this on a bunch of other structs once I followed the thread from your comment. |
Thanks, I renamed the tiny remaining items. |
I think the PR is ready to go as-is. Since we're already bumping the cache version, we should decide before the next release whether we also want to change |
I think I did change |
5cb7b7f
to
d0d7bc6
Compare
Summary
This is now consistent with
requires_dist
(singular).