Warn when using uv_build settings without uv_build
#15750
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
konstin
temporarily deployed
to
uv-test-registries
GitHub Actions
Inactive
konstin
commented
Sep 12, 2025
crates/uv-build-frontend/src/lib.rs
Outdated
| "There are settings for the `uv_build` build backend defined in \ | ||
| `tool.uv.build-backend`, but the project does not use the `uv_build` backend: {}", |
There was a problem hiding this comment.
One potential drawback is that we assume that all future versions will have build-system = "uv_build".
konstin
force-pushed
the
konsti/warn-on-unused-build-backend-settings
branch
from
fad531f to
0226753
Compare
konstin
temporarily deployed
to
uv-test-registries
GitHub Actions
Inactive
zsol
approved these changes
Sep 16, 2025
zanieb
reviewed
Sep 16, 2025
crates/uv/tests/it/build_backend.rs
Outdated
Comment on lines
1059
to
1061
| warning: There are settings for the `uv_build` build backend defined in `tool.uv.build-backend`, but the project does not use the `uv_build` backend: [TEMP_DIR]/pyproject.toml | ||
| Building wheel from source distribution... | ||
| warning: There are settings for the `uv_build` build backend defined in `tool.uv.build-backend`, but the project does not use the `uv_build` backend: [CACHE_DIR]/sdists-v9/[TMP]/pyproject.toml |
There was a problem hiding this comment.
Can we avoid warning multiple times here?
There was a problem hiding this comment.
I need to figure our something that works despite the different paths
zanieb
reviewed
Sep 16, 2025
zanieb
reviewed
Sep 16, 2025
crates/uv/tests/it/build_backend.rs
Outdated
| ----- stderr ----- | ||
| Building source distribution... | ||
| warning: There are settings for the `uv_build` build backend defined in `tool.uv.build-backend`, but the project does not use the `uv_build` backend: [TEMP_DIR]/pyproject.toml |
There was a problem hiding this comment.
We might want to rephrase so it's clearer what we're referring to at the end, e.g., "but the uv_build backend is not used by the project at: PATH"
konstin
temporarily deployed
to
uv-test-registries
GitHub Actions
Inactive
konstin
temporarily deployed
to
uv-test-registries
GitHub Actions
Inactive
Co-authored-by: Zanie Blue <[email protected]>
konstin
force-pushed
the
konsti/warn-on-unused-build-backend-settings
branch
from
44c9302 to
a7d14f7
Compare
konstin
temporarily deployed
to
uv-test-registries
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To help with cases such as #15655.
A question is when to show this warning. I've used sources as a proxy as URL dependencies with enabled sources are likely those controlled by the user, and they include workspace and
git cloned path dependencies.The first commit is a refactoring, the second commit the implementation.
Fixes #15740