Skip to content

Refuse to remove non-virtual environments in uv venv #15538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 26, 2025
Merged

Refuse to remove non-virtual environments in uv venv #15538

merged 2 commits into from
Aug 26, 2025

Conversation

charliermarsh
Copy link
Member

Summary

Closes #15474.

Base automatically changed from charlie/cwd to main August 26, 2025 16:43
@charliermarsh charliermarsh requested a review from zanieb August 26, 2025 16:43
@charliermarsh charliermarsh added the bug Something isn't working label Aug 26, 2025
@charliermarsh charliermarsh marked this pull request as ready for review August 26, 2025 16:44
@charliermarsh
Copy link
Member Author

I'm a little wary of doing this for non-interactive terminals since it's breaking... I wonder if we should just warn in that case like we do today.

@notatallshaw
Copy link
Collaborator

I'm a little wary of doing this for non-interactive terminals since it's breaking... I wonder if we should just warn in that case like we do today.

As long as I can get the behavior where it throws an error, see also #15475

As someone who writes scripts having commands behave differently when I run them locally vs CI is maddening and makes it really difficult to debug what went wrong.

@zanieb
Copy link
Member

zanieb commented Aug 26, 2025

For what it's worth, this is a pretty clear regression from #14309. I don't think we should be deleting arbitrary directories without opt-in.

I think the only questionable part is when --clear is explicitly provided. I would be okay deferring that to a future release.

@zanieb
Copy link
Member

zanieb commented Aug 26, 2025

As long as I can get the behavior where it throws an error, see also #15475

I think we should definitely not prompt for non-virtual environments.

@zanieb
Copy link
Member

zanieb commented Aug 26, 2025

(I don't think you need to keep saying that you don't like the TTY behavior, I think your point is clear there)

@charliermarsh
Copy link
Member Author

Ah I see, yeah it is a regression in that case. Okay, let's ship this for non---clear, and leave --clear as-is?

@notatallshaw
Copy link
Collaborator

(I don't think you need to keep saying that you don't like the TTY behavior, I think your point is clear there)

Noted, it wasn't clear to me @charliermarsh was aware of that discussion.

zanieb
zanieb reviewed Aug 26, 2025
View reviewed changes
zanieb
zanieb reviewed Aug 26, 2025
View reviewed changes
zanieb
zanieb approved these changes Aug 26, 2025
View reviewed changes
Copy link
Member

@zanieb zanieb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 presuming we defer the breaking change in OnExisting::Remove

@charliermarsh charliermarsh merged commit 9eb5fc2 into main Aug 26, 2025
95 of 96 checks passed
@charliermarsh charliermarsh deleted the charlie/clear branch August 26, 2025 17:26
@BrewTestBot BrewTestBot mentioned this pull request Aug 28, 2025
Merged
tmeijn pushed a commit to tmeijn/dotfiles that referenced this pull request Sep 2, 2025
@tmeijn
build(deps): update astral-sh/uv to v0.8.14
8650760 
This MR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [astral-sh/uv](https://github.com/astral-sh/uv) | patch | `0.8.13` -> `0.8.14` |

MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot).

**Proposed changes to behavior should be submitted there as MRs.**

---

### Release Notes

<details>
<summary>astral-sh/uv (astral-sh/uv)</summary>

### [`v0.8.14`](https://github.com/astral-sh/uv/blob/HEAD/CHANGELOG.md#0814)

[Compare Source](astral-sh/uv@0.8.13...0.8.14)

##### Python

- Add managed CPython distributions for aarch64 musl

##### Enhancements

- Add `--python-platform` to `uv pip check` ([#&#8203;15486](astral-sh/uv#15486))
- Add an environment variable for `UV_ISOLATED` ([#&#8203;15428](astral-sh/uv#15428))
- Add logging to the uv build backend ([#&#8203;15533](astral-sh/uv#15533))
- Allow more trailing null bytes in zip files ([#&#8203;15452](astral-sh/uv#15452))
- Allow pinning managed Python versions to specific build versions ([#&#8203;15314](astral-sh/uv#15314))
- Cache PyTorch wheels by default ([#&#8203;15481](astral-sh/uv#15481))
- Reject already-installed wheels that don't match the target platform ([#&#8203;15484](astral-sh/uv#15484))
- Add `--no-install-local` option to `uv sync`, `uv add` and `uv export`  ([#&#8203;15328](astral-sh/uv#15328))
- Include cycle error message in `uv pip` CLI ([#&#8203;15453](astral-sh/uv#15453))

##### Preview features

- Fix format of `{version}` on `uv format` failure ([#&#8203;15527](astral-sh/uv#15527))
- Lock during installs in `uv format` to prevent races ([#&#8203;15551](astral-sh/uv#15551))
- Respect `--project` in `uv format` ([#&#8203;15438](astral-sh/uv#15438))
- Run `uv format` in the project root ([#&#8203;15440](astral-sh/uv#15440))

##### Configuration

- Add file-to-CLI overrides for build isolation configuration ([#&#8203;15437](astral-sh/uv#15437))
- Add file-to-CLI overrides for reinstall configuration ([#&#8203;15426](astral-sh/uv#15426))

##### Performance

- Cache `WHEEL` and `METADATA` reads in installed distributions ([#&#8203;15489](astral-sh/uv#15489))

##### Bug fixes

- Avoid erroring when creating `venv` in current working directory ([#&#8203;15537](astral-sh/uv#15537))
- Avoid introducing unnecessary system dependency on CUDA ([#&#8203;15449](astral-sh/uv#15449))
- Clear discovered site packages when creating virtual environment ([#&#8203;15522](astral-sh/uv#15522))
- Read index credentials from the environment during `uv publish` checks ([#&#8203;15545](astral-sh/uv#15545))
- Refuse to remove non-virtual environments in `uv venv` ([#&#8203;15538](astral-sh/uv#15538))
- Stop setting `CLICOLOR_FORCE=1` when calling build backends ([#&#8203;15472](astral-sh/uv#15472))
- Support file or directory removal for Windows symlinks ([#&#8203;15543](astral-sh/uv#15543))

##### Documentation

- Fix GitHub guide highlight lines ([#&#8203;15443](astral-sh/uv#15443))
- Move Resolver to new Internals section in the Reference ([#&#8203;15465](astral-sh/uv#15465))
- Split the "Authentication" page into sections ([#&#8203;15575](astral-sh/uv#15575))
- Update uninstall docs to mention `uvw.exe` needs to be removed ([#&#8203;15536](astral-sh/uv#15536))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this MR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box

---

This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MS44OC4wIiwidXBkYXRlZEluVmVyIjoiNDEuODguMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiUmVub3ZhdGUgQm90Il19-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zanieb zanieb zanieb approved these changes

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

uv venv -c . wipes working directory and fails to create a venv

3 participants

@charliermarsh @notatallshaw @zanieb