Add no clear option for uv venv #15485
Closed
+203
−41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanieb
reviewed
Aug 24, 2025
zanieb
reviewed
Aug 24, 2025
Aditya-PS-05
force-pushed
the
add-no-clear-option
branch
from
6af4133 to
11e36e9
Compare
Aditya-PS-05
force-pushed
the
add-no-clear-option
branch
from
11e36e9 to
1755831
Compare
zanieb
reviewed
Aug 25, 2025
Comment on lines
+122
to
+123
| if allow_prompt { | ||
| match confirm_clear(location, name)? { |
There was a problem hiding this comment.
I'd use match allow_prompt.then(|| confirm_clear(..)).flatten() so we don't need to indent the match and repeat the error message construction.
There was a problem hiding this comment.
(You might need .transpose()?.flatten() to handle the error still)
zanieb
added a commit
that referenced
this pull request
Sep 16, 2025
<!-- Thank you for contributing to uv! To help us out with reviewing, please consider the following: - Does this pull request include a summary of the change? (See below.) - Does this pull request include a descriptive title? - Does this pull request include references to any relevant issues? --> Closes #15485 --------- Co-authored-by: Aditya-PS-05 <[email protected]> Co-authored-by: Zanie Blue <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #15475
Test Plan
I created tests for 4 scenarios