Remove UpgradeSelection struct
#15422
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
added
the
internal
charliermarsh
temporarily deployed
to
uv-test-registries
GitHub Actions
Inactive
konstin
approved these changes
Aug 21, 2025
charliermarsh
force-pushed
the
charlie/up
branch
from
c1f8282 to
b3f278f
Compare
charliermarsh
temporarily deployed
to
uv-test-registries
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
After #15395, I realized that we didn't actually need a separate struct for this since we now pass it around as an
Option. (The key change from #15395 is that when combining, we treat the options as a single unit.)