-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Add extra-build-dependencies
hint for any missing module on build failure
#15252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add extra-build-dependencies
hint for any missing module on build failure
#15252
Conversation
27cd247
to
c9459e3
Compare
… package. Add additional hints for `pip` and `setuptools`
c9459e3
to
d9940bd
Compare
Sorry I broke |
I think you can test this with something like Lines 1571 to 1601 in 323aa8f
|
I'm a little worried about the impact it will have on binary size, did you check a release build before and after? |
Not much of an increase, only 32kbs more ❯ du -sk uv_with_pipreqs
45240 uv_with_pipreqs
❯ du -sk uv_without_pepreqs
45208 uv_without_pepreqs |
[tool.uv.extra-build-dependencies] | ||
"anyio" = ["setuptools"] | ||
or `uv pip install setuptools` into the environment and re-run with `--no-build-isolation`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fwiw this instruction isn't sufficient, because then they also need to install all of the other build dependencies of anyio
. I'm hesitant to suggest it without that additional information (and broadly hesitant to suggest it at all).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I thought about this, but this matches the current hint we give for people facing issues with torch
so I figured we shouldn't remove that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think now that we have the extra build dependencies it's actually okay to remove that, but... I'm okay with considering that separately. Can you open a tracking issue?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
extra-build-dependencies
hint for any missing module on build failure
This MR contains the following updates: | Package | Update | Change | |---|---|---| | [astral-sh/uv](https://github.com/astral-sh/uv) | patch | `0.8.9` -> `0.8.11` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>astral-sh/uv (astral-sh/uv)</summary> ### [`v0.8.11`](https://github.com/astral-sh/uv/blob/HEAD/CHANGELOG.md#0811) [Compare Source](astral-sh/uv@0.8.10...0.8.11) ##### Python - Add Python 3.14.0rc2 - Update Pyodide to 0.28.1 ##### Enhancements - Add Debian 13 trixie to published Docker images ([#​15269](astral-sh/uv#15269)) - Add `extra-build-dependencies` hint for any missing module on build failure ([#​15252](astral-sh/uv#15252)) - Make 'v' prefix cyan in overlap warnings ([#​15259](astral-sh/uv#15259)) ##### Bug fixes - Fix missing uv version in extended Docker image tags ([#​15263](astral-sh/uv#15263)) - Persist cache info when re-installing cached wheels ([#​15274](astral-sh/uv#15274)) ##### Rust API - Allow passing custom `reqwest` clients to `RegistryClient` ([#​15281](astral-sh/uv#15281)) ### [`v0.8.10`](https://github.com/astral-sh/uv/blob/HEAD/CHANGELOG.md#0810) [Compare Source](astral-sh/uv@0.8.9...0.8.10) ##### Python - Add support for installing Pyodide versions ([#​14518](astral-sh/uv#14518)) ##### Enhancements - Allow Python requests with missing segments, e.g., just `aarch64` ([#​14399](astral-sh/uv#14399)) ##### Preview - Move warnings for conflicting modules into preview ([#​15253](astral-sh/uv#15253)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MS42Ni4yIiwidXBkYXRlZEluVmVyIjoiNDEuNzEuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiUmVub3ZhdGUgQm90Il19-->
Alternative to #15251.
As suggested in #15118 (comment)
Test Plan
cargo test